TypeScript 6 upgrade + architectural deepening - #15
Merged
Conversation
- Move extractWaveformData to electron/main/audio/waveform.ts; WAV parsing no longer embedded in an IPC handler - Push getAllSamples filters to SQL WHERE clauses; was O(n) full-table scan with in-memory filter - Add applyProfileFormat to hardware/profiles.ts; callers no longer reach into profile.format.* directly, and the duplicate ffmpeg config across packs and audio IPC handlers is removed - Add analyzeAudioUrl URL cache and move save-chops orchestration (analyze + persist) into the library store; AudioWaveform no longer owns that flow - Add withLoading helper and apply it across all load-bracket actions; fixes a latent bug in library.fetchSamples where isLoading would stick on IPC error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
TypeScript 6
typescriptto 6.0.3, fixed tsconfig for TS6 compatibilityArchitecture refactors
extractWaveformDatafrom the library IPC handler intoelectron/main/audio/waveform.tsgetAllSamplesfilters down to SQL WHERE clauses (was O(n) in-memory scan)applyProfileFormattohardware/profiles.ts; removed duplicated ffmpeg config fromipc/packs.tsandipc/audio.tsanalyzeAudioUrlURL cache; moved save-chops orchestration (analyze + persist) intolibrary.saveChopsstore actionwithLoadinghelper insrc/stores/utils.ts; applied across all load-bracket store actions; fixed latent bug inlibrary.fetchSampleswhereisLoadingwould stick on IPC errorDocs
services/export.ts)