add native Windows support - #3
Merged
Merged
Conversation
RubenGlez
marked this pull request as ready for review
August 7, 2026 06:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
doctier unlockwith a current-user-only, inheritance-protected NTFS DACLdoctier unlockreveal them securely even with an unmerged indexWhy
Git owns the destination of smudge filters and copies merge-driver output into the worktree. On Windows, either operation can create a file with inherited permissions before doctier can apply an owner-only DACL. Returning plaintext from those subprocesses would create an exposure window.
Windows therefore uses a ciphertext handoff. Checkout and conflicted merges leave ciphertext in the worktree;
doctier unlockowns the final write, protects the real path first, then writes plaintext.Windows ARM64 still only cross-compiles, so it is deliberately excluded from release artifacts until native validation exists.
Impact
Windows x64 users can install a checksum-verifiable release ZIP and use doctier with Git for Windows. After checkout, pull or a conflicted private merge, they run
doctier unlockto materialize private content securely. Linux and macOS behavior is unchanged. Windows archives are not Authenticode-signed yet.Validation
go test ./...(104 tests),go vet ./...andgo build ./...doctier unlockmaterializes plaintext behind one protected current-user ACEdoctier unlockreveals conflict markers, and the final file keeps the protected DACLf12044a