feat(DarkTheme): Dark theme via CSS-variable token engine - #4054
Draft
m7kvqbe1 wants to merge 11 commits into
Draft
feat(DarkTheme): Dark theme via CSS-variable token engine#4054m7kvqbe1 wants to merge 11 commits into
m7kvqbe1 wants to merge 11 commits into
Conversation
m7kvqbe1
changed the title
m7kvqbe1
force-pushed
the
feat/dark-mode-token-set
branch
3 times, most recently
from
June 29, 2026 21:15
383c363 to
f595ea2
Compare
|
Important Testing in progress…🟢 UI Tests: 254 tests unchanged |
|
Tip All tests passed and all changes approved!🟢 UI Tests: 254 tests unchanged |
m7kvqbe1
force-pushed
the
feat/dark-mode-token-set
branch
from
June 30, 2026 09:06
f595ea2 to
1d2e66c
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A — exploratory spike / draft.
Overview
Adds a working dark theme to the design system. A CSS‑variable token engine themes the whole library (including content rendered through portals) with no per‑component edits, backed by a genuine dark colour token set, a Storybook Light/Dark toggle, and per‑component contrast/polish tuning. Light mode is unchanged.
Link to preview
Storybook: toggle the paintbrush (Light/Dark) on any story.
Reason
Evaluate a dark theme for RNDS that can be toggled alongside light, with great contrast and no regressions to the existing light theme.
Work carried out
color()emitsvar(--color-<group>-<weight>, <lightFallback>);GlobalStyleProviderinjects the active theme's--color-*at:root(so portals theme too)colorValue()for fixed/foreground colours;colorByMode(group, lightShade, darkShade)so dark tweaks never touch lighttokens/dark/colors.json)colorByMode)Screenshot
To add: Storybook Button/DataGrid/Modal in Light vs Dark.
Developer notes
color()now returnsvar(--color-…, <hex>)instead of a raw hex when no theme is threaded. Anything asserting a raw hex, or feedingcolor()intopolished, should use the newcolorValue(). In‑repo cases are already converted.colorValue; theme‑specific shades usecolorByMode.