build(Hosting): Migrate from Netlify to GitHub Pages - #981
Merged
Conversation
markhigham
commented
Feb 9, 2026
markhigham
commented
Collaborator
- Add GitHub Pages deployment workflow with manual trigger support
- Add CNAME for custom domain (docs.design-system.navy.digital.mod.uk)
- Add static export script to package.json
- Configure Next.js with unoptimized images for static export
- Remove Netlify configuration and branch deploy preview workflow
markhigham
force-pushed
the
deploy-storybook-master-gh-pages
branch
from
February 9, 2026 17:10
f98a112 to
322c4a4
Compare
markhigham
force-pushed
the
deploy-storybook-master-gh-pages
branch
from
February 9, 2026 17:22
8e67c9f to
2d0b860
Compare
m7kvqbe1
reviewed
Feb 10, 2026
|
|
||
| module.exports = withTM({ | ||
| images: { | ||
| unoptimized: true, |
Collaborator
There was a problem hiding this comment.
Do we need this we didn't do this before?
Collaborator
Author
There was a problem hiding this comment.
unoptimized: true is required because GitHub Pages doesn’t support Next’s image optimizer
| @@ -0,0 +1 @@ | |||
| docs.design-system.navy.digital.mod.uk | |||
Collaborator
There was a problem hiding this comment.
Is this for GitHub pages configuration then?
Collaborator
Author
There was a problem hiding this comment.
apparently so but there's also an option in the web ui
Comment on lines
8
to
+9
| "build": "next build", | ||
| "export": "next build && next export", |
Collaborator
There was a problem hiding this comment.
What does next export do that next build didn't?
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} | ||
| # - name: SonarCloud Scan |
Collaborator
There was a problem hiding this comment.
How come we need to turn this off?
Collaborator
Author
There was a problem hiding this comment.
Broken - we probably need a new token
- Add GitHub Pages deployment workflow with manual trigger support - Add CNAME for custom domain (docs.design-system.navy.digital.mod.uk) - Add static export script to package.json - Configure Next.js with unoptimized images for static export - Remove Netlify configuration and branch deploy preview workflow Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
markhigham
force-pushed
the
deploy-storybook-master-gh-pages
branch
from
February 13, 2026 13:28
2d0b860 to
219073c
Compare
m7kvqbe1
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.