Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes appear consistent, self-contained, and aligned with the PR goal of syncing already-landed main commits without introducing new functional risk.
Pull request overview
Syncs dev with recent main commits by incorporating UI/layout tweaks, timing instrumentation, and documentation improvements across the visualizer and terminal components.
Changes:
- Adds step-generation timing measurement in the engine and surfaces it in the right sidebar inspector.
- Improves canvas layout responsiveness by switching several horizontal UI groups to wrapped layouts.
- Standardizes time handling for cross-platform/wasm compatibility by moving from
std::time::{Instant,SystemTime}toweb_timewhere needed, and adds clarifying doc comments to model enums/taxonomy.
File summaries
| File | Description |
|---|---|
| src/ui/inspector.rs | Displays engine step-generation time in the right sidebar inspector. |
| src/ui/canvas/collections.rs | Improves layout for collection visualizations via wrapped horizontal layouts and minor spacing tweaks. |
| src/ui/ai_chat_dock.rs | Switches to web_time::Instant for message timestamps/boot timing compatibility. |
| src/terminal.rs | Uses web_time::SystemTime for quiz seeding in a wasm-friendly way. |
| src/model/visual_state.rs | Adds per-variant documentation to clarify what each visualization state represents. |
| src/model/taxonomy.rs | Adds documentation for theme/accessibility and taxonomy enums to improve readability. |
| src/engine.rs | Measures step generation duration and stores it on the app state. |
| src/app.rs | Updates app state to store timing metadata and migrates Instant usage to web_time. |
Review details
- Files reviewed: 8/8 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Update README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Synchronizes
devwith the four commits already present onmain.This restores the integration branch before the Contains Duplicate visual fix and the Engine-label cleanup are proposed through the normal maintainer workflow.
Related Issues
N/A
Type of Change
Verification Checklist
maindevbranch