fix: correct SHA256 typo, update machine images, scope build workflows to master/tags#122
Open
circleci-app[bot] wants to merge 1 commit into
Open
fix: correct SHA256 typo, update machine images, scope build workflows to master/tags#122circleci-app[bot] wants to merge 1 commit into
circleci-app[bot] wants to merge 1 commit into
Conversation
- Fix CIRCLE_SHA2256 typo (extra '2') in build-linux-amd64 Build step; same class of bug fixed in #120/#121 but this instance was missed - Upgrade ubuntu-2004:202201-02 → ubuntu-2204:current for both Linux machine executor jobs (amd64 and arm64) - Add branch/tag filters to build_linux, build_windows, build_macos workflows so they only run on master or v* tags instead of every branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CIRCLE_SHA2256typo inbuild-linux-amd64"Build with build.spec" step — an extra2in the variable name caused an empty short SHA, producing malformed artifact filenames. The same class of bug was addressed in Correct CIRCLE_SHORT_SHA1 to CIRCLE_SHORT_SHA256 #120 and Update build file name to use CIRCLE_SHA256 #121 but this instance was missed.ubuntu-2004:202201-02→ubuntu-2204:currentfor bothbuild-linux-amd64andbuild-linux-arm64jobs.build_linux,build_windows, andbuild_macosso they only trigger on themasterbranch orv*tags — previously every push to every branch kicked off expensive build jobs unnecessarily.Test plan
all_testworkflow still triggers on feature branches (no filters applied there)master(or create av*tag) and confirm all four build workflows triggerhttps://app.circleci.com/agents/gh/Rose2161/chat/a10a2625-1eae-4b07-9620-87af25dd5e2d