Several Improvements - #10
Open
RojhatToptamus wants to merge 5 commits into
Open
Conversation
Implement durable, typed user-input lifecycles for Codex and OpenCode so native questions retain provider choices, custom and free-text answers, exact run/session/server ownership, single-delivery fencing, and explicit cancellation, disconnect, restart, and ambiguous-delivery behavior. Keep unsupported ACP prose questions on the existing follow-up path. Harden restricted Codex Git access, OpenCode reconciliation, interaction projection and persistence validation, and the renderer form against stale ownership, duplicate submissions, multiplicity errors, and provider-event races. Add deterministic adapter, policy, storage, API, seed, and DOM coverage. Upgrade the supported Electron/Node/Vite toolchain and repair the macOS alpha release path with explicit ad-hoc signing, archive verification, packaged runtime/preview relaunch checks, and safeStorage Keychain isolation. Update workflow, runtime, protocol, seeding, installation, and release documentation to match the implemented behavior.
Reconcile interrupted worktree, Git, branch publication, pull-request, provider-session, interaction, review, and Preview state against the system that owns each result. Adopt proven completion, reconnect proven active work, and keep ambiguous external mutations blocked instead of replaying persisted intent. Add an IPC-owned child-process boundary for provider runtimes, mutating and remote Git operations, GitHub CLI work, and Docker/Compose commands so abrupt application exit terminates only exact Task Monki-owned process trees. Preserve existing graceful shutdown and exact Preview ownership cleanup. Separate Continue work from Retry implementation in actions, prompts, activity, and policy. Gate every delivery entry point against unresolved publication state before auto-commit, and add real process-restart, local-remote, provider-protocol, storage, renderer, packaging, and documentation coverage.
Add a deterministic ACP subprocess runner that drives TaskManagerService through completion, failure, and cancellation in fully owned temporary repositories and worktrees. Verify protocol activity, workflow projections, independent Git evidence, actionable failure diagnostics, and complete process and resource cleanup, with an optional authenticated browser-development UI. Document the layered testing strategy and research behind it, distinguish seeded UI inspection from executed workflows and paid provider smoke tests, and expose the workflow consistently in developer guidance.
Add deterministic stress and UI stress coverage for accumulated history, concurrent output, large Git evidence, Preview cycles, provider loss and restart, and bounded soak cleanup. Keep durable task state authoritative while reusing its published serialization, bounding provider text only in client projections, and coalescing selected-task activity refreshes without rebuilding snapshots for hidden or raw output. Document the stress workflow, client projection limit, renderer refresh cadence, measurements, and cleanup expectations.
Split renderer reads into compact board and task-detail projections, route bounded invalidations through generation-guarded refreshes, and preserve authoritative durable provider evidence. Add browser reconnect fallback, cross-task dependency refreshes, UTF-8-safe provider text excerpts with explicit artifact metadata, deterministic stress coverage, regression tests, and updated architecture and testing documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several important updates to documentation and configuration, focusing on improved workflow testing, updated Node.js requirements, and expanded technical guidance for agent orchestration, recovery, and user input handling. The changes clarify development and testing practices, enhance the accuracy of workflow descriptions, and ensure the documentation reflects the latest platform and protocol expectations.
Testing and workflow documentation improvements:
npm run test:agent-workflowcommand for executed workflow and agent lifecycle testing, including guidance on when to use UI inspection (-- --ui). UpdatedAGENTS.md,README.md, anddocs/DEV_SEEDING.mdto clarify the distinction between seeded and executed workflow tests and when each is appropriate. [1] [2] [3]docs/PRODUCT_WORKFLOW.md, clarifying the difference between Continue work and Retry implementation, and documenting the handling of native user input requests. [1] [2] [3]Platform and configuration updates:
.github/workflows/ci.yml,.github/workflows/release.yml) and in the main README to ensure compatibility with the latest features and dependencies. [1] [2] [3]Technical guidance and architecture:
These updates collectively improve the clarity, safety, and reliability of the development and testing process, and ensure the documentation is aligned with current and future workflow requirements.