⚡ Bolt: Reuse requests.Session in OllamaClient - #22
Conversation
Co-authored-by: Rohith-Shimori <228351330+Rohith-Shimori@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Refactored
OllamaClientto initialize arequests.Sessionobject in__init__and reuse it for all API calls (generate,chat,stream).🎯 Why:
The previous implementation created a new TCP connection (and potential SSL handshake) for every single request to the Ollama API. This adds unnecessary latency, especially for frequent or small requests.
📊 Impact:
🔬 Measurement:
Added
tests/test_ollama_session.pywhich mocksrequests.Sessionand verifies thatsession.postis called instead ofrequests.post. The test passes, confirming the optimization is active.PR created automatically by Jules for task 7054791749103307812 started by @Rohith-Shimori