Rename box height to length - #14
Merged
Merged
Conversation
Boxes are rectangles on a floor plan, not 3D volumes, so "width and length" better describes the two editable dimensions than "width and height". Renames Box.height to Box.length across the type, canvas rendering, and properties panel, and adds a storage migration (v1->v2) so existing persisted plans and imported .snapdraft.json files with the old `height` field are transparently upgraded.
✅ Deploy Preview for snapdraftfloorplans ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Box.heightfield toBox.lengththroughout the app (type, canvas rendering, properties panel), since a box's two dimensions are better described as width/length than width/height.data-testid="box-length-input") instead of "Height".FLOORPLAN_VERSION1 → 2) so existing persisted plans and imported.snapdraft.jsonfiles that still have the oldheightfield are transparently upgraded tolengthon load/import.Test plan
npm run test— 330 unit tests passing, including new migration tests instorage.test.tsnpm run test:e2e— 250 Playwright tests passing (chromium + iPad), including the metric-import test that exercises the legacy v1height→lengthmigration path end-to-endnpm run build— clean production buildnpm run lint— clean