feat: add Arabic (ar) language support with RTL layout - #150
Merged
Conversation
Fall back to English when update metadata is not translated, prevent the feature announcement from crashing, and give translated settings layouts the space they need.
Owner
|
Add some small fixes and now it is very nice, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Arabic (
ar) language support to wnr, including a full translation and RTL (right-to-left) layout support for the Settings, Timer, and Statistics windows.What's included
locales/ar.jsonfull Modern Standard Arabic translationar/العربيةto the language arrays insupporter.js,main.js, andar-TNto the NSIS installer languages inres/builder/nsis.js[dir="rtl"]CSS overrides for the Settings page and a dedicated.rtl-timerclass for the Timer and Statistics time displaysi18n.__()'s return value in a Unicode First Strong Isolate (U+2068/U+2069) when the locale is Arabic, this way every string returned by the translation function is automatically isolated, regardless of where it's later concatenated or displayed.Testing
=== 'ar'or.startsWith('ar')) with no fallthrough, and I confirmed each locale's UI, timer, and statistics pages render identically to before this changeAlso added French (fr) translation support – full French localization included with locales/fr.json.