feat: metrics_path add password; connected_slave_lag is the delay cou…#71
Open
tclxjing8-li wants to merge 1 commit into
Open
feat: metrics_path add password; connected_slave_lag is the delay cou…#71tclxjing8-li wants to merge 1 commit into
tclxjing8-li wants to merge 1 commit into
Conversation
…nt of writebatch, remove seconds
git-hulk
reviewed
Nov 11, 2025
| "commands_duration_seconds_bucket": {txt: `Histogram of the amount of time in seconds spent per command`, lbls: []string{"cmd"}}, | ||
| "commands_duration_seconds_total": {txt: `Total amount of time in seconds spent per command`, lbls: []string{"cmd"}}, | ||
| "commands_total": {txt: `Total number of calls per command`, lbls: []string{"cmd"}}, | ||
| "connected_slave_lag_seconds": {txt: "Lag of connected slave", lbls: []string{"slave_ip", "slave_port", "slave_state"}}, |
Member
There was a problem hiding this comment.
This change will cause a compatibility issue for other users. It should be good to keep the same name with Redis but has different meaning.
Author
There was a problem hiding this comment.
Adding 'second' may lead to ambiguity in understanding
Member
There was a problem hiding this comment.
@tclxjing8-li Yes, I totally agree with your point. Perhaps we could change the description in txt field to clarify this. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: metrics_path add password; connected_slave_lag is the delay count of writebatch, remove seconds.