This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[WIP] RC Xcode-11 workaround#2781
Open
bobrenji wants to merge 9 commits into
Open
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Please note this branch is still [WIP]. Please help me to review.
Issue 1: After successful login, app shows black screen
How to produce: Run on Xcode -11 [Fixed as a work around]
Issue 2: App always shows notification view on top of the screen. [Fixed as a work around]
Soln: NotificationViewController.shared.notificationViewIsHidden = true add as a work around. But not able to figure out what is the root cause.
Issue 3: SearchBar in SubscriptionsViewController shows navigation bar without background color.
once search view appears, navigation bar background color become transparent. [No solution yet]