Skip to content
This repository was archived by the owner on Jun 7, 2020. It is now read-only.

[NEW] Add FAB, Show list of contacts, Invite Contacts via Email / Phone#1853

Open
kb0304 wants to merge 19 commits into
RocketChat:developfrom
kb0304:contacts_2
Open

[NEW] Add FAB, Show list of contacts, Invite Contacts via Email / Phone#1853
kb0304 wants to merge 19 commits into
RocketChat:developfrom
kb0304:contacts_2

Conversation

@kb0304

@kb0304 kb0304 commented Nov 13, 2018

Copy link
Copy Markdown
Contributor

@rafaelks

Copy link
Copy Markdown
Contributor

@kb0304 You will need to use the same branch name on the SDK to run the tests here.

@kb0304

kb0304 commented Nov 13, 2018

Copy link
Copy Markdown
Contributor Author

@rafaelks I have created a PR to the SDK, could you please create a new branch in the SDK?

@philipbrito philipbrito left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting feature. My only concern is about the usage of the twilio API since it involves payments (https://www.twilio.com/pricing).

maybe @rafaelks can put his thoughts here.

@bizzbyster

bizzbyster commented Nov 27, 2018

Copy link
Copy Markdown
Contributor

@filipedelimabrito the plan is to create a configuration setting which specifies which custom field in the profile to use to store mobile phone number. If that is not set, then mobile phone number is not part of the profile and invites/contacts will only be supported via email. Of course, if an admin has Twilio setup then they can take advantage of the mobile phone number aspect of the feature as well. Does that make sense to you and @rafaelks ?

@rafaelks

rafaelks commented Dec 3, 2018

Copy link
Copy Markdown
Contributor

@bizzbyster Yes, I guess we can use this setting, but why do we need Twilio on the mobile-side? To send the invitation to the user? Shouldn't this call be made from the back-end?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create new chat via '+' FAB button on inbox

4 participants