Skip to content

WIP: Tests for ROS 2 action client - #131

Closed
tetov wants to merge 11 commits into
RobotWebTools:mainfrom
tetov:test_ros2_actionlib
Closed

tetov wants to merge 11 commits into
RobotWebTools:mainfrom
tetov:test_ros2_actionlib

Conversation

@tetov

@tetov tetov commented May 4, 2025

Copy link
Copy Markdown
Contributor

Depends on #125 and #130.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke check).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@tetov

tetov commented May 4, 2025

Copy link
Copy Markdown
Contributor Author

Currently looking into how to easily stand up an action server in the ros 2 container. (Problem importing from example interfaces)

@sea-bass

sea-bass commented Jul 28, 2025 •

Copy link
Copy Markdown

Currently looking into how to easily stand up an action server in the ros 2 container. (Problem importing from example interfaces)

You can add ros-<version>-example-interfaces to the list here:

ros-iron-rosbridge-suite \

Edit: actually you may want to add rosbridge_test_msgs: https://github.com/RobotWebTools/rosbridge_suite/tree/ros2/rosbridge_test_msgs

Also, ROS 2 Iron has been out of support for over a year now. I would recommend swapping this container out for an active LFS version (humble or jazzy), but ideally to matrix it for all active releases (humble, jazzy, kilted, rolling).

@bjsowa in case you're interested

@sea-bass

Copy link
Copy Markdown

lol never mind, I just saw (and merged) your other PR. Thanks @tetov!

@gonzalocasas

Copy link
Copy Markdown
Contributor

@tetov @sea-bass thanks, guys for the work in here! This is now superseded by the changes in #143, so I will close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants