fix(docs): resolve doc-gen4 before docs build (lets Pages deploy)#22
Merged
Conversation
The Docs workflow ran the initial `lake exe cache get` without -Kenv=dev, which elaborated and cached a lakefile config that omits the conditional doc-gen4 dev dependency. The later `lake -Kenv=dev build FormalSLT:docs` reused that cached config, so doc-gen4 was never cloned and its `docs` library facet stayed unregistered, failing with "unknown lean_lib facet `docs`". Run the cache-get step with -Kenv=dev so the first Lake invocation elaborates the config with doc-gen4 active and clones it (plus its transitive deps) alongside the Mathlib olean download. The conditional dev-dependency design is unchanged; the normal build stays doc-gen4-free.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe GitHub Actions docs workflow's cache retrieval step was renamed and modified to run ChangesDocs Workflow Cache Update
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First lake command runs with -Kenv=dev so doc-gen4's docs facet registers before the build. Validated on run 28635186013 — build-docs green, full mathlib doc closure built in ~57m, artifact uploaded; deploy waited on the main-only branch policy. Merging publishes.
Summary by CodeRabbit