CI: make PR runs reliable; fix black gate#15
Merged
Conversation
- ci.yml/tests.yml: trigger on pull_request `synchronize` so the suite re-runs on every push to an open PR (was only opened/reopened). - tests.yml: mark the Codecov upload `continue-on-error` — fork PRs have no repo secrets, so the upload is rejected; coverage is informational and must not fail a contributor's PR. - Run `black .` across the repo. The `quality` job runs `black --check .` over the whole tree; the unformatted mcp/ files (and the expanded tests.py) were turning every PR red. Formats tests/tests.py + 4 mcp/ files; no behavior change. The 67-test battery in tests/tests.py passes against a freshly built wheel in a clean venv (the CI path). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Local black (22.12.0) and CI's latest (26.5.1) disagreed on mcp/examples/enzyme_kinetics_agent.py, so the quality job still failed. Pin both tools in ci.yml so the style is deterministic across PRs, and reformat the repo with the pinned black. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes CI green and reliable for incoming PRs. The
CI/qualityworkflow was failing onmaster(latest run failed in 16s) becauseblack --check .rejects unformatted files anywhere in the repo, and the recently-addedmcp/files weren't formatted — that would fail every PR too.Changes
black .across the repo (formatstests/tests.py+ 4mcp/files; no behavior change).black --check .now passes.pull_request: synchronizetoci.ymlandtests.ymlso the suite re-runs on every push to an open PR (was only opened/reopened, so later commits went untested).continue-on-error— fork PRs have no repo secrets, so the upload is rejected; coverage is informational and shouldn't fail a contributor's PR.Test battery
tests/tests.pyis a fixed, deterministic battery of 67 unittest cases driven by the committedtests/fixtures/brenda_sample.json(no network, no large data). Verified passing against a freshly built wheel in a clean venv — the exact CI path (poetry build && pip install dist/*.whl && coverage run -m unittest discover tests).🤖 Generated with Claude Code