Add configurable parallel downloads#25
Open
nittanygeek wants to merge 3 commits into
Open
Conversation
Owner
|
Thanks for the PR. Do you find this makes a noticeable speed increase for your downloads? I’m not seeing much difference on my A229 Pro which struggles with multiple connections. I often get the "slow card" message and I am wondering about the performance/thermal impact on the camera. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DOWNLOAD_CONCURRENCYsetting for 1-4 simultaneous downloadsTesting
PYTHONPATH=. .venv311/bin/python -m pytest tests/test_queue_ro_only.py tests/test_settings_schema.py tests/test_settings_api.py tests/test_sync_worker_cancel.py tests/test_sync_worker_enospc.py tests/test_sync_worker_concurrency.py tests/test_hub.py tests/test_hub_session_stats.py tests/test_download_session.pynode --check web/static/app.jsAlso tested manually against a Viofo dashcam with
DOWNLOAD_CONCURRENCY=4, confirming four active downloads and continuous slot refilling.