v4: Add and expose prop querying#478
Merged
Merged
Conversation
This allows to debug the value of all unknown props found in firmware disassembly. Might be useful to debug and find new features. TODO: Hook it to HA
This reverts commit 122edc3.
This reverts commit 488dba7.
Move the logic and reuse it in the device. Exposes query_props and query_props_all on the device level
Adds 2 services to query specific or all device properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main change in this PR is the addition of methods in the API to directly query device props. This is surfaced in HA by two actions, one for all known props (as in, found by inspecting the firmware), and one for user-defined props. This allows for better debugging and for easier adding of new features by asking users to dump prop states. As a benefit, all status requests to the device use the same method to query the props.
Other changes:
@RobHofmann, you can create a release after merging this one. Don't forget to set it as a pre-release.