Skip to content

feat(wcl): add encounter selection for uploads - #6

Merged
RobDeFlop merged 5 commits into
mainfrom
feat/issue-4-upload-selection
Aug 13, 2026
Merged

feat(wcl): add encounter selection for uploads#6
RobDeFlop merged 5 commits into
mainfrom
feat/issue-4-upload-selection

Conversation

@RobDeFlop

@RobDeFlop RobDeFlop commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add a scan-and-select modal for raid encounters, Mythic+ dungeons, and PvP activities before upload.
  • Filter one-shot uploads to the selected fight sequences and expose progress/error events.
  • Preserve existing-data backfill for live logging and handle log rotation safely.
  • Add structural sequence parsing and regression coverage for Mythic+ markers, including failed runs.
  • Display activity timestamps, durations, status, difficulty, keystone level, and PvP format in the selection UI.

Why

Warcraft Logs combat logs can contain many non-encounter events, and Mythic+ markers are not reliably represented by the simplified event parser. Scan and upload now share the same raw-log sequence boundaries, so M+ runs are classified and selectable instead of appearing as other fights.

Validation

  • cargo fmt --check
  • cargo test --lib (35 tests)
  • cargo clippy --all-targets -- -D warnings
  • bunx tsc --noEmit
  • bun run build
  • git diff --check

@RobDeFlop
RobDeFlop marked this pull request as ready for review August 13, 2026 01:29
@RobDeFlop
RobDeFlop merged commit e8c5fcd into main Aug 13, 2026
1 check passed
@RobDeFlop
RobDeFlop deleted the feat/issue-4-upload-selection branch August 13, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant