Conversation
…cs, and WebSocket upgrade detection on shared port Implement an HTTP server as the primary listener using Node.js built-in http module, with WebSocketServer running in noServer: true mode. Incoming requests are inspected for the Upgrade header to correctly route WebSocket upgrades vs plain HTTP requests. Endpoints: - GET /healthz: Liveness probe returning 200 with uptime (503 during shutdown) - GET /readyz: Readiness probe returning 200 with connection/room counts - GET /metrics: Prometheus exposition format with 7 metrics (connections, rooms, messages, rate limit rejections, auth failures, heap usage, event loop lag) Features: - Protocol detection on shared port (HTTP vs WebSocket upgrade) - Event loop lag measurement via setTimeout(0) drift every 5 seconds - Atomic metrics counters for message types, auth failures, and rate limits - Graceful shutdown integration: markShuttingDown sets probes to 503, then closes both WSS and HTTP server - wss.address() patched to return httpServer.address() for test compatibility Closes #199
feat: Co-located HTTP server with health checks, Prometheus metrics, and WebSocket upgrade detection (#199)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge