Skip to content

[EPAC-2308]: Sync ComputeBillVersionDiff catalog with all-pair generation#828

Merged
riddim-developer-bot[bot] merged 1 commit into
mainfrom
symphony/epac-2308-sync-computebillversiondiff-catalog-with-all-pai
Jun 15, 2026
Merged

[EPAC-2308]: Sync ComputeBillVersionDiff catalog with all-pair generation#828
riddim-developer-bot[bot] merged 1 commit into
mainfrom
symphony/epac-2308-sync-computebillversiondiff-catalog-with-all-pai

Conversation

@riddim-developer-bot

Copy link
Copy Markdown
Contributor

Summary

  • Catalog-only sync: docs/architecture/use-case-catalog.md still described ComputeBillVersionDiff as consecutive-pair generation, but EPAC-2302 changed the implementation to emit BillDiff records for every valid ordered version pair (with adjacent-pair artifacts still emitted unconditionally for smoke/evidence compatibility). The catalog now matches the implementation.
  • Updates the ComputeBillVersionDiff entry's Goal and Outputs, and adds a Pair selection rule callout describing the i < j iteration, the adjacent-pair carve-out (preserves consecutive-pair artifacts even when text is missing), and the "both sides have parsed clause text" gate for non-adjacent pairs.
  • Clarifies LoadBillVersionDiff Outputs to explicitly distinguish HTTP 200 with clauses: [] for the no-change comparable case from nil / HTTP 404 for the unavailable case, matching backend/bills/internal/usecase/bills.go.

No code or behavior changes.

Closes EPAC-2308.

Verification

  • scripts/ci/check_catalog_drift.sh — passes locally (no implementation paths or iOS port rows touched).
  • Manual diff review against backend/bills-indexer/internal/usecase/compute_bill_version_diff.go and backend/bills/internal/usecase/bills.go to confirm the new wording matches the actual policy.
  • Self-review confirmed all four acceptance criteria in the Linear issue.

Simulator verification is skipped: this PR touches only architecture documentation; no app, API, CLI, or script output changes.

Test plan

  • CI: pr-build green.

…tion

The bills-indexer use-case policy was updated by EPAC-2302 to emit
BillDiff records for every valid ordered version pair (with adjacent
pairs still emitted unconditionally for smoke/evidence compatibility),
but the use-case catalog still described consecutive-pair generation
only. Update the ComputeBillVersionDiff entry's Goal, Outputs, and add a
Pair selection rule to match the implementation. Clarify
LoadBillVersionDiff's Outputs to distinguish HTTP 200 with `clauses: []`
for no-change comparable diffs from nil/unavailable behavior for
unsupported pairs.

Catalog-only; no code or behavior changes.
@riddim-developer-bot
riddim-developer-bot Bot enabled auto-merge (squash) June 15, 2026 12:28
@riddim-developer-bot
riddim-developer-bot Bot merged commit af449b8 into main Jun 15, 2026
35 checks passed
@riddim-developer-bot
riddim-developer-bot Bot deleted the symphony/epac-2308-sync-computebillversiondiff-catalog-with-all-pai branch June 15, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants