[EPAC-2067]: fix Swift 6 strict concurrency errors in Fetch.swift#598
Merged
riddim-developer-bot[bot] merged 1 commit intoMay 25, 2026
Conversation
Replace locally-created ISO8601DateFormatter instances threaded through parsing methods with a single actor-isolated stored property. The formatter was being passed as a non-Sendable parameter across async suspension points, which Xcode 26.3's strict concurrency checker flags as a data race risk. As actor-isolated state the formatter's access is serialized by the actor and never crosses isolation boundaries.
riddim-developer-bot
Bot
added
the
autonomous
riddim-developer-bot
Bot
deleted the
symphony/epac-2067-ci-testflight-build-failing-on-main
branch
May 25, 2026 19:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ISO8601DateFormatter(non-Sendable) being passed as a parameter across async suspension points in theFetchactorISO8601DateFormatterinstances (voting records + written questions) with a singlevoteDateFormatterstored property on the actor, eliminating the need to thread the formatter through eight private parsing methodsWhy
The CI TestFlight build (run 26414979202) fails at archive with three errors:
The
loadVotingPagemethod isasyncand passes a non-SendableISO8601DateFormatteracross theawait fetchJSONDictionary()suspension point. Xcode 26.3's stricter Swift 6 concurrency checking correctly identifies this as a potential data race.Verification
xcodebuild buildpasses locally (BUILD SUCCEEDED)swiftlint --strictshows no new violations (45 pre-existing, none in Fetch.swift)Skipped checks
Resolves EPAC-2067
Reviewer-Boundary: review-only