[EPAC-2059]: delete dead search manifest entry and supersede tsvector decision doc#589
Merged
riddim-developer-bot[bot] merged 1 commit intoMay 25, 2026
Conversation
… decision doc - Remove `search` service from backend/manifest/deployment-services.json (no backend/search/ directory ever existed; entry caused Terraform to provision a ghost Lambda on every apply) - Remove /search and /search/speeches from retiredPaths in backend/openapi/main_test.go - Add docs/architecture/search-index-choice-v2.md: SQLite FTS5 in S3 is the actual v1 search architecture (supersedes EPAC-452 tsvector decision) - Mark docs/architecture/search-index-choice-epac452.md as superseded (body retained as historical context) - Update CLAUDE.md project overview to reference v2 decision doc - Deleted orphan epac-search-staging Lambda function in AWS (orphan from prior Terraform apply; confirmed epac-search-production was never created)
riddim-developer-bot
Bot
added
the
autonomous
riddim-developer-bot
Bot
deleted the
symphony/epac-2059-delete-dead-search-manifest-entry-and-supersede
branch
May 25, 2026 17:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Cleans up vestigial search infrastructure that contradicted the actual architecture and would cause Terraform to provision a ghost Lambda (
epac-search-staging/epac-search-production) on every apply. Also supersedes the EPAC-452 tsvector decision doc, which predates the Aurora retirement and the S3-artifact migration.What changed
searchservice entry frombackend/manifest/deployment-services.json. Nobackend/search/directory ever existed; the entry was purely a deployment ghost./searchand/search/speechesfromTestRetiredLambdaPathsAreAbsent— those paths are no longer tracked endpoints and don't need to be asserted absent.docs/architecture/search-index-choice-v2.mddocuments the actual v1 decision: SQLite FTS5 in S3, queried by a stateless Lambda pulling to/tmpon cold start. Covers trade-offs vs tsvector and vs managed search (OpenSearch/Meilisearch), out-of-scope items (bilingual French stemming, scheduled refresh, cross-session search), and implementation pointers to thehansard-search-indexandhansard-searchLambdas.docs/architecture/search-index-choice-epac452.mdupdated with a## Status: Supersededbanner at the top pointing at v2; body retained as historical context.epac-search-stagingLambda function (confirmedepac-search-productionwas never created).Trade-offs not taken
Could have left the
retiredPathslist unchanged (keeping/searchand/search/speechesas documented retired paths). Removed them instead — the paths belong to the deleted service and there's no evidence they were ever live, so tracking their absence adds noise without value.Verification
All backend tests pass. iOS build not required (no app code changed).
Resolves EPAC-2059
Reviewer-Boundary: review-only