[EPAC-2036]: implement Saskatchewan MLA member directory adapter#584
Merged
riddim-developer-bot[bot] merged 1 commit intoMay 25, 2026
Conversation
riddim-developer-bot
Bot
deleted the
symphony/epac-2036-implement-saskatchewan-mla-member-directory-adap
branch
May 25, 2026 14:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SaskatchewanMemberDirectoryAdapterto parse the Legislative Assembly roster HTML intoParliamentMemberrows tagged withJurisdiction.saskatchewanSchemaV9migration support forParliamentMember.jurisdictionplus a storeddirectoryKeyso federal and Saskatchewan members can coexist without name collisionsFetch.downloadMembers(jurisdiction:)and add roster fixture plus adapter/runtime migration testsVerification
scripts/check-boundaries.shcd ios && make buildcd ios && xcodebuild build-for-testing -project epac.xcodeproj -scheme epac -destination 'platform=iOS Simulator,id=A42F2FBA-FC7A-4EFF-8F85-C402A8850ED6' -derivedDataPath .build -only-testing:epacTests/SaskatchewanMemberDirectoryAdapterTests -only-testing:epacTests/RuntimeDataPathTests -only-testing:epacTests/MigrationPlanTests -only-testing:epacTests/ModelTests -quiet | xcbeautify --quietpython3 scripts/localization/check_localizations.py --github-warningscd ios && swiftlint lint --strict epacTests/RuntimeDataPathTests.swift epacTests/Hansard/SaskatchewanMemberDirectoryAdapterTests.swift epac/Model/Fetch.swift epac/Data/Adapters/Hansard/SaskatchewanMemberDirectoryAdapter.swift epac/Model/Model.swiftSkipped / blocked
cd ios && xcodebuild test ...could not run in this container because simulator launches fail withIDEPseudoTerminalDomain Code=7/openpty: Device not configuredbefore tests execute.cd ios && swiftlint --strictis not clean on this branch before or after this change because of existing repo-wide violations, including vendored.build/SourcePackagesfiles and unrelated test targets.python3 scripts/localization/check_localizations.py --github-warningsstill reports the pre-existing missing keyonboarding.welcome.titlein both English and French tables.Reviewer-Boundary: review-only