Skip to content

[EPAC-2036]: implement Saskatchewan MLA member directory adapter#584

Merged
riddim-developer-bot[bot] merged 1 commit into
mainfrom
symphony/epac-2036-implement-saskatchewan-mla-member-directory-adap
May 25, 2026
Merged

[EPAC-2036]: implement Saskatchewan MLA member directory adapter#584
riddim-developer-bot[bot] merged 1 commit into
mainfrom
symphony/epac-2036-implement-saskatchewan-mla-member-directory-adap

Conversation

@riddim-developer-bot

Copy link
Copy Markdown
Contributor

Summary

  • add SaskatchewanMemberDirectoryAdapter to parse the Legislative Assembly roster HTML into ParliamentMember rows tagged with Jurisdiction.saskatchewan
  • add SchemaV9 migration support for ParliamentMember.jurisdiction plus a stored directoryKey so federal and Saskatchewan members can coexist without name collisions
  • wire Saskatchewan member ingestion through Fetch.downloadMembers(jurisdiction:) and add roster fixture plus adapter/runtime migration tests

Verification

  • scripts/check-boundaries.sh
  • cd ios && make build
  • cd ios && xcodebuild build-for-testing -project epac.xcodeproj -scheme epac -destination 'platform=iOS Simulator,id=A42F2FBA-FC7A-4EFF-8F85-C402A8850ED6' -derivedDataPath .build -only-testing:epacTests/SaskatchewanMemberDirectoryAdapterTests -only-testing:epacTests/RuntimeDataPathTests -only-testing:epacTests/MigrationPlanTests -only-testing:epacTests/ModelTests -quiet | xcbeautify --quiet
  • python3 scripts/localization/check_localizations.py --github-warnings
  • cd ios && swiftlint lint --strict epacTests/RuntimeDataPathTests.swift epacTests/Hansard/SaskatchewanMemberDirectoryAdapterTests.swift epac/Model/Fetch.swift epac/Data/Adapters/Hansard/SaskatchewanMemberDirectoryAdapter.swift epac/Model/Model.swift

Skipped / blocked

  • cd ios && xcodebuild test ... could not run in this container because simulator launches fail with IDEPseudoTerminalDomain Code=7 / openpty: Device not configured before tests execute.
  • cd ios && swiftlint --strict is not clean on this branch before or after this change because of existing repo-wide violations, including vendored .build/SourcePackages files and unrelated test targets.
  • python3 scripts/localization/check_localizations.py --github-warnings still reports the pre-existing missing key onboarding.welcome.title in both English and French tables.

Reviewer-Boundary: review-only

@riddim-developer-bot riddim-developer-bot Bot added the autonomous Enrolled in prconverged daemon for automated review and merge label May 25, 2026
@riddim-developer-bot
riddim-developer-bot Bot enabled auto-merge (squash) May 25, 2026 14:16
@riddim-developer-bot
riddim-developer-bot Bot merged commit b72b0ae into main May 25, 2026
5 checks passed
@riddim-developer-bot
riddim-developer-bot Bot deleted the symphony/epac-2036-implement-saskatchewan-mla-member-directory-adap branch May 25, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autonomous Enrolled in prconverged daemon for automated review and merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants