[EPAC-2035]: Implement Saskatchewan recorded votes parser#583
Merged
sunnypurewal merged 3 commits intoMay 25, 2026
Merged
Conversation
auto-merge was automatically disabled
May 25, 2026 17:44
Pull request was closed
sunnypurewal
force-pushed
the
symphony/epac-2035-implement-saskatchewan-recorded-votes-parser
branch
from
May 25, 2026 18:26
b4d87cb to
c8e611a
Compare
Contributor
Author
|
Post-rebase update:
Residual functional gap from the current branch: the Saskatchewan votes parser/persistence hook exists, but no live Saskatchewan adapter call site invokes it yet. |
sunnypurewal
deleted the
symphony/epac-2035-implement-saskatchewan-recorded-votes-parser
branch
May 25, 2026 18:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Saskatchewan recorded-votes parsing was implemented on an older schema head and then drifted behind
main. This update keeps the PR branch compatible with the current migration graph while preserving the new parser, fixture, and tests.What changed
SaskatchewanVotesParserplus a Saskatchewan Votes and Proceedings XML fixture and parser tests.Fetch.ingestSaskatchewanVotes(document:sittingDate:)to persist parsed Saskatchewan votes.main'sSchemaV9member-jurisdiction migration and moved the vote-jurisdiction change into a newSchemaV10with aV9 -> V10migration.ModelContainersetup to use the latest schema head.Trade-offs not taken
ingestSaskatchewanVotes(...)yet.SaskatchewanVotesParserremains a stub returning no votes; this fix pass focused on finishing the rebase safely instead of inventing a broader HTML parsing strategy during PR repair.Test plan
cd ios && make buildResult: passed after rebasing onto
origin/main. The only warning is the pre-existingSchemaV5.RecordedVoteredundantSendableconformance already present onmain.cd ios && make testResult: failed before running the PR's tests because the vendored
Evidencepackage does not compile in this environment:.build/SourcePackages/checkouts/evidence/Sources/Evidence/EvidenceApplication.swift:113:9: 'open' is only available in iOS 16.4 or newer.swiftlint --strictResult: repo-wide failure from unrelated baseline violations in other targets (
epacUITests,epac-clip,epac-widget, etc.)./opt/homebrew/bin/swiftlint lint --strict <path>Result: passed for every file changed in this PR.
python3 scripts/localization/check_localizations.py --github-warningsResult: reported the pre-existing missing
onboarding.welcome.titlekey in both English and French.Refs EPAC-2035
Reviewer-Boundary: review-only