fix: Add safety net to prevent TypeError from unsupported 'encrypt' kwarg - #38
Open
edinsonsan wants to merge 1 commit into
Open
fix: Add safety net to prevent TypeError from unsupported 'encrypt' kwarg#38edinsonsan wants to merge 1 commit into
edinsonsan wants to merge 1 commit into
Conversation
… kwarg in pymssql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Users downloading the package via pip are encountering a TypeError: connect() got an unexpected keyword argument 'encrypt'. While the explicit config["encrypt"] assignment was removed in recent commits, legacy environments or older package caches might still inject this keyword, causing pymssql.connect(**config) to crash completely.
Fix:
Added a defensive check at the end of get_db_config() to ensure the "encrypt" key is explicitly removed from the config dictionary before it's passed as **kwargs to the database connector. This protects the server from crashing while keeping the new connection-string-based encryption logic intact.
Also, could you please cut a new release to PyPI (e.g., v0.1.1)? The current pip version (0.1.0) is severely out of sync with main and still contains the old bug.