fix(parse): decode src before parsing - #478
Merged
Merged
Conversation
YogliB
reviewed
Aug 1, 2026
Collaborator
|
Thanks for the contribution! |
Collaborator
|
Hi @haohanyang — I verified the fix and it resolves #477 correctly. The new test passes too. Two small things before this can land:
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What
Decode the URL/src before parsing to get correct
subdirWhy
Fix - #477. The PR fixes parsed subdir from
%40typesto@typesLinked issues
#477
Changes
Decode
srcusingdecodeURIComponent(src);onsrc\domain\repo.ts:parseTesting
How you verified this (commands, scenarios, or N/A):
bun run test)Review notes
Breaking changes (or none)
Risks / rollout (or none)
Focus areas for reviewers (optional)
Checklist