Skip to content

fix(parse): decode src before parsing - #478

Merged
YogliB merged 5 commits into
Rich-Harris:masterfrom
haohanyang:master
Aug 2, 2026
Merged

fix(parse): decode src before parsing#478
YogliB merged 5 commits into
Rich-Harris:masterfrom
haohanyang:master

Conversation

@haohanyang

@haohanyang haohanyang commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

What
Decode the URL/src before parsing to get correct subdir
Why
Fix - #477. The PR fixes parsed subdir from %40types to @types

Linked issues

#477

Changes

Decode src using decodeURIComponent(src); on src\domain\repo.ts:parse

Testing

How you verified this (commands, scenarios, or N/A):

  • Automated tests (bun run test)
  • Manual / CLI check if user-facing behavior changed
  • CI passes

Review notes

Breaking changes (or none)

Risks / rollout (or none)

Focus areas for reviewers (optional)

Checklist

  • Error paths and exit codes considered where relevant
  • Help text, completions, or docs updated if user-facing strings changed
  • Squashed to a single commit
  • No unrelated drive-by changes

@haohanyang
haohanyang requested a review from YogliB as a code owner July 31, 2026 17:35
Comment thread src/domain/repo.ts Outdated
@YogliB

YogliB commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the contribution!
Left a small comment, and approved the CI.

@YogliB

YogliB commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Hi @haohanyang — I verified the fix and it resolves #477 correctly. The new test passes too.

Two small things before this can land:

  1. The Quality check is failing because src/domain/repo.ts needs formatting. Could you run bun run format and push the result?
  2. Please add an unreleased note to docs/CHANGELOG.md for this fix.

Thanks!

@YogliB
YogliB merged commit 101228a into Rich-Harris:master Aug 2, 2026
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants