Urgent, change temp file folder from "tmp" to mkdtemp - #14
Open
anttiryt wants to merge 3 commits into
Open
Conversation
changes required to use tempfile mkdtemp() original code would potentially wipe out tmp -named directory on destination video's folder.
Renamed output_filename to data_path in extract_frames() for consistency with other code.
removed output_path, is not used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original code would potentially wipe out tmp -named directory on destination video's folder.
Luckily the inference crashed on unknown file formats and I didn't lose my .. stuff..