fix(cli): nest workflow run config in update_run_config request body - #11
Draft
anamhira47 wants to merge 1 commit into
Draft
fix(cli): nest workflow run config in update_run_config request body#11anamhira47 wants to merge 1 commit into
anamhira47 wants to merge 1 commit into
Conversation
The API expects run_config and override_run_config at the top level. The CLI was sending a flat WorkflowRunConfig payload, causing validation errors on workflow config set. Co-authored-by: Anam Hira <anam@revyl.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes REV-377:
revyl workflow config setfailed with validation errors because the CLI sent a flat run-config payload instead of the nested shape the API expects.Changes
UpdateWorkflowRunConfigbody as{ "run_config": { ... }, "override_run_config": <bool> }, consistent withUpdateWorkflowLocationConfigandUpdateWorkflowBuildConfig.workflow config setpassesoverride_run_config: truewhen applying parallelism/retries.wf.OverrideRunConfigand set it when editing parallelism or max retries.OverrideRunConfigto theWorkflowAPI model for parity with other override flags.Test plan
go test ./internal/api/... ./cmd/revyl/... ./internal/tui/...revyl workflow config set <workflow> --parallel 3 --retries 1against staging/production APILinear Issue: REV-377