fix(playscan): drop redundant clause from the Play Billing fix line - #18
Merged
Conversation
The fix text read "upgrade to 8.x or higher, migrating through 8 if you are on 7", which is circular, and it repeated the no-direct-7-to-9 explanation already carried in the finding's detail. The fix line now states only the action to take.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy-only. Caught while scanning purpose-built Android test apps.
The Play Billing finding's fix line read:
That is circular, and the no-direct-7-to-9 point is already made in the finding's detail text. The fix line now carries only the action:
No behaviour change, no test changes needed.
Note
Low Risk
User-facing remediation text only; scan rules and billing version checks are unchanged.
Overview
Copy-only change to the Play Billing Library scan finding in
rulePlayBillingVersion.The Fix field no longer appends “migrating through 8 if you are on 7,” which duplicated the detail text and read circularly (“upgrade to 8.x … migrating through 8”). It now only says to upgrade
com.android.billingclient:billingto 8.x or higher (viaminSupportedBillingMajor). Detail text is unchanged and still explains the no direct 7→9 path.No rule logic, severity, or detection behaviour changes.
Reviewed by Cursor Bugbot for commit 6b8342c. Bugbot is set up for automated code reviews on this repo. Configure here.