Keep properties reactive when a model gets instrumented by Vue mid-constructor.#38
Merged
Conversation
Member
Author
|
@codex review Triggered automatically because this PR was opened ready for review or was marked ready for review. |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
pkaminski
changed the title
Typically we'd wrap all properties before Vue instruments a model. However, if the model gets passed into a call while the constructor is still running, and the call happens to add it to previously- instrumented object, then Vue will instrument the model early. We must then be very careful not to overwrite Vue's accessors with our own wrappers or the property will stop being reactive!
earlAchromatic
left a comment
earlAchromatic
left a comment
Contributor
There was a problem hiding this comment.
@earlAchromatic reviewed 10 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pkaminski).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typically we'd add and wrap all properties before Vue instruments a model. However, if the model gets passed into a call while the constructor is still running, and the call happens to add it to previously- instrumented object, then Vue will instrument the model early. We must then be very careful not to overwrite Vue's accessors with our own wrappers or the property will stop being reactive. We must also make sure that any properties added afterwards (such as computed ones) get instrumented by Vue and trigger any watchers already installed on the model.
I'm honestly not sure I would've figured this out without Codex.
This change is