Skip to content

extract iwTree.cpp - #56

Closed
morganchristiansson wants to merge 1 commit into
Return-To-The-Roots:masterfrom
morganchristiansson:iwtree
Closed

extract iwTree.cpp#56
morganchristiansson wants to merge 1 commit into
Return-To-The-Roots:masterfrom
morganchristiansson:iwtree

Conversation

@morganchristiansson

Copy link
Copy Markdown
Contributor

callbacks.cpp is 3293 lines in master.
I thought it makes sense to split it to smaller files.
s25client has pattern with one window per cpp file in libs/s25main/ingameWindows/ so maybe do the same here?

Was going to start with texture window but that will conflict with other open PRs so start with tree window.
discuss.

@Flamefire

Copy link
Copy Markdown
Member

To be blunt: What is the advantage? It is just moving code around so looks like work without a benefit. Large files compile faster than many smaller ones and it works 🤷

@morganchristiansson

Copy link
Copy Markdown
Contributor Author

Fair point.
I just think callbacks.cpp is becoming dumping ground for all UI component callbacks and it will grow as further changes are made.
s25client has very small files per window I thought it could be nicer organisation.
But after actually scrolling through callbacks.cpp I realized it's not so bad actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants