Persist screen resolution - #44
Merged
Flamefire merged 7 commits intoJun 23, 2026
Merged
Conversation
Flow86
reviewed
Jun 22, 2026
| libsiedler2::Archiv settings; | ||
| if(libsiedler2::Load(settingsPath, settings) != 0) | ||
| return; | ||
| const auto* ini = static_cast<const libsiedler2::ArchivItem_Ini*>(settings.find("editor")); |
Member
There was a problem hiding this comment.
shouldn't it be a dynamic_cast here?
Contributor
Author
There was a problem hiding this comment.
Fixed. Thank you for your review!
Flow86
reviewed
Jun 22, 2026
| libsiedler2::Archiv settings; | ||
| settings.alloc(1); | ||
| settings.set(0, std::make_unique<libsiedler2::ArchivItem_Ini>("editor")); | ||
| auto* ini = static_cast<libsiedler2::ArchivItem_Ini*>(settings.find("editor")); |
Member
There was a problem hiding this comment.
Actually not required here as you just put that one in. So this cannot fail. It could use a dynamic cast with a reference to make that clear(er), but not so important
Flamefire
reviewed
Jun 23, 2026
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
Flamefire
reviewed
Jun 23, 2026
| return; | ||
| GameResolution.x = ini->getValue("width", static_cast<int>(GameResolution.x)); | ||
| GameResolution.y = ini->getValue("height", static_cast<int>(GameResolution.y)); | ||
| fullscreen = ini->getValue("fullscreen", static_cast<int>(fullscreen)) != 0; |
Member
There was a problem hiding this comment.
Suggested change
| fullscreen = ini->getValue("fullscreen", static_cast<int>(fullscreen)) != 0; | |
| fullscreen = ini->getValue("fullscreen", fullscreen); |
Flamefire
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also increase resolution list height and add 4K UHD.
Fixes #20