Fixing crash in CampaignSelection - #1803
Merged
Merged
Conversation
.. since no campaign selection is done up until that point by the user.
Flamefire
requested changes
Sep 29, 2025
Flamefire
left a comment
Flamefire
left a comment
Member
There was a problem hiding this comment.
Good catch!
Minor enhancement to avoid the lookup and casting
Flamefire
previously approved these changes
Sep 29, 2025
Flamefire
enabled auto-merge
September 29, 2025 15:13
Flamefire
reviewed
Sep 29, 2025
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
auto-merge was automatically disabled
September 29, 2025 15:17
Head branch was pushed to by a user without write access
Flamefire
approved these changes
Sep 29, 2025
Flamefire
enabled auto-merge
September 29, 2025 15:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Summary
In the campaign selection screen, it is possible to click "next" without previously selecting any campaign from the table, which results in a crash. This PR fixes it by having the "next" button disabled upon creation.