Assert that the runtime-ext version matches channel version - #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the base structure and the internal version from the channel's version.h to
shared/version.h, so that it can be included in both runtime-ext and the channel. runtime-ext stores it in a static with a fixed address that's then read and compared in the channel with its own version.Then I've renamed version.h in the channel to versionutils.h since it doesn't contain the version struct itself anymore, just additional utils that the channel needs and ones that are not needed for runtime-ext.
I also removed the dummy reads in the
_startfunction in runtime-ext which were meant to stop the linker from removing symbols that seem "unused", and replaced them withKEEP()in the linker script. IMO this is more obvious and less error-prone (compiler could technically be smart enough to realize the dummy pointer reads don't do anything).