fix(consensus): disable unsafe LPIPS early stopping - #13
Merged
Conversation
The existing 20x delta-threshold heuristic is not a proven upper bound on per-clip LPIPS advantage. A challenger can therefore fall behind early, exceed that assumed bound on later clips, and be rejected even though the complete duel would crown it. Add an explicit consensus-pinned enablement flag that ships disabled, pass no bound to the evaluator while disabled, and expose the setting in dashboard metadata. Add an adversarial late-comeback regression and cover the flag's required-field and consensus-digest behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The existing 20x delta-threshold heuristic is not a proven global upper bound on per-clip LPIPS advantage. A challenger can fall behind on early clips, exceed that assumed bound later, and be rejected even though the completed duel would crown it.
Consensus impact
The enablement flag participates in the consensus digest. Validators and eval servers must deploy the same chain configuration.
Testing