Repository navigation
[Fixed] Teams: share keys no longer wait for the share picker on every key - #135
Merged
Merged
Conversation
…y key The `if (key == "s" || key == "q")` had no braces, so the 10 s wait for the share picker ran on every key and ended in an unhandled rejection. Add the braces, and catch the timeout when no picker is shown (stopping an ongoing share). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KG9a9jCghzpRda7TtbkRmV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
teams.js,if (key == "s" || key == "q")had no braces. Only the click on the share button was conditional. The 10 s wait for the share picker ran on every key (1–5, c…) and ended in an unhandled rejection. It could also click a share picker opened for another reason.Fix
Braces around the share block. The picker wait is wrapped in try/catch: when stopping a share (
q), no picker is shown and that is not an error.Tests (Teams meeting, Cisco Room Kit)
svia VIDEO_SLIDES_START): content visible in the Teams client ✅q): content removed ✅; second start/stop cycle ✅