Repository navigation
[Fixed] BBB family: recording consent accepted with key 6 in any UI language - #134
Merged
Merged
Conversation
…anguage - Select the recording notice button by data-test="recordingNotifyContinue" (aria-label is translated, so the English selector never matched a French UI); the old aria-label stays as a fallback for older BBB. - Key 6: add the missing braces in webinaire.js and bbbesr.js (the joinAudio check ran on every key) and stop throwing when no notice is shown (also in bigbluebutton.js). - browse(): in a recordable meeting (recordingIndicator present), wait up to 3 s for the notice, which BBB renders after the audio modal closes. - browse(): handle key 6 while waiting for acceptance; the IVR menu key listener is only installed once joined, so the wait could only end on its 120 s timeout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KG9a9jCghzpRda7TtbkRmV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In BBB-based connectors (Webinaire, BBB ESR, BigBlueButton), key 6 is meant to accept the recording notice ("Recording started / Continue"). It did not work:
if (key == "6")ran the joinAudio check on every key and threw when no notice was shown;Fix
[data-test='recordingNotifyContinue'], with the old aria-label kept as a fallback.recordingIndicatorpresent), wait up to 3 s for the notice after joining audio. There is no extra delay in non-recordable meetings. The recording state itself is only exposed through translated aria-labels, so it is not used.finally.Tests (Webinaire, French UI, Cisco Room Kit)
BBB ESR and BigBlueButton use the same BBB component but were not tested live.