Fix assume_effects :foldable for non-concrete types#59
Merged
Conversation
A function marked `:foldable` must terminate for any inputs. There is no guarantee that type parameters will be concrete (and in fact, during abstract evaluation in the compiler, there's every possibility they won't be), but these functions must still terminate.
kpamnany
reviewed
Jan 27, 2026
|
Also, CI is broken because of |
Member
Author
|
oops, fixed the typos thank you! |
kpamnany
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A function marked
:foldablemust terminate for any inputs. There is no guarantee that type parameters will be concrete (and in fact, during abstract evaluation in the compiler, there's every possibility they won't be), but these functions must still terminate.