Fix release assembly versioning - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
1.6.1and update package documentationRoot cause
The
1.6.0workflow compiled with the repository's staleVersionPrefixof1.3.0, then suppliedPackageVersion=1.6.0only to a laterdotnet pack --no-build. NuGet therefore contained a correctly versioned package wrapping DLLs whose assembly, file, and informational metadata remained1.3.0.Validation
1.6.0package becauseBitsKit.Generator.dllis1.3.0.01.6.1: all shipped DLLs report assembly/file version1.6.1.0and product version1.6.1+<commit>0.0.0-ci.999to cover prerelease-version handling-NoBuildAfter merge, tag the resulting master commit as
v1.6.1to publish the corrected package.