Harden source generation and diagnostics - #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
byte[], and emit escaped, fully qualified identifiers and framework/library referencesbyte*behavior explicit: checked mode reportsBITSKIT009, while unsafe mode generates direct pointer accessBITSKIT007–BITSKIT014BitFieldAttributeWhy
The generator previously depended on display strings and generated all bit objects as one output. Legal nullable/keyword/shadowing cases could produce invalid C#, a malformed declaration could affect unrelated objects, and raw pointers were wrapped as zero-length checked spans. These changes make generated output deterministic, symbol-correct, isolated, and diagnosable.
Validation
dotnet build BitsKit.sln -c Release --no-restoredotnet test BitsKit.sln -c Release --no-build(4,616 tests on both .NET 8 and .NET 10)dotnet pack BitsKit/BitsKit.csproj -c Release --no-build--list flatRegression coverage includes nullable arrays, unsafe raw pointers, keyword identifiers, consumer types shadowing framework names, same-named objects in separate namespaces, invalid-object and invalid-field isolation, derived attributes, and all new diagnostics.