Add opt-in unsafe generated accessors - #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BitObjectAccessMode.Unsafeas an explicit source-generator opt-in while preserving checked generation as the defaultMemory<byte>,Span<byte>, arrays, fixed buffers, and inline arraysUnsafeBitPrimitivesfor the underlying unchecked operationsThis PR intentionally does not include the planned batch API; that will be a separate change.
Performance
AMD Ryzen 9 9900X, .NET 10.0.8, BenchmarkDotNet MediumRun. All cases allocate 0 B.
Memory<byte>operationThe complete 99-case benchmark suite also completed successfully using ShortRun.
Safety contract
Unsafe mode is never inferred. Callers must guarantee non-empty, stable, sufficiently padded backing storage for every generated access. Violating that contract can cause out-of-bounds access, data corruption, information disclosure, or process failure. Checked access remains the default.
Validation
1.6.0-preview.1: passedgit diff --check: passed