Specialize generated byte storage accessors - #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This combines the remaining generated-accessor optimizations into one change:
Span<byte>,ReadOnlySpan<byte>, byte arrays, and byte InlineArraysMemoryMarshal.AsBytesfor eligible byte InlineArray fieldsMemory-backed booleans intentionally remain on
BitPrimitives: focused measurements showed that repeatedly acquiring.Spanmade direct generated code slower. Span and byte-InlineArray booleans use the direct path.Why
The generator knows storage kind, field width, offset, signedness, and bit order at compile time. Eligible layouts can avoid the general primitive dispatch/validation path while preserving the existing generated API and falling back safely for exact-size buffers.
Performance
Paired BenchmarkDotNet comparisons against merge commit
9179007:Correctness and compatibility
Validation
dotnet test BitsKit.Tests/BitsKit.Tests.csproj -c Release --no-restoredotnet build BitsKit.sln -c Release --no-restoredotnet pack BitsKit/BitsKit.csproj -c Release --no-build --no-restoregit diff --check9179007