Integrate incremental generator fixes and restore BITSKIT003 - #2
Merged
Conversation
…doesn't do anything useful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompilationProviderBITSKIT003for supported memory-backed bit fields that omit their requiredFieldTypeBITSKIT003regression coverageMicrosoft.Bcl.HashCoderuntime dependencyWhy
The generator previously re-ran for insignificant compilation changes and retained compiler objects in its incremental pipeline, which can cause IDE performance and memory problems. Upstream PR #5 fixes that architecture but intentionally omitted
BITSKIT003; this integration restores the diagnostic without reintroducing non-incremental state.Validation
actionlintAttribution
The upstream incremental-generator work remains authored by ZingBallyhoo through the preserved merge history.