Optimize generated MSB scalar setters - #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
BitPrimitivesfallback for memory-backed fields, native integers, and invalid rangesWhy
Generated MSB setters previously called the general-purpose
BitPrimitives.Write*MSBmethods even though the source generator knows the backing width, bit offset, and field width at compile time. The generated expression now contains the precomputed destination mask and only the required value mask, shift, byte-order operation, and assignment.This primarily improves cold and Tier-0 generated code. Tier-1 already optimized the old helper chain effectively, so warmed-up throughput remains tied.
Performance
Representative Dry disassembly runs:
The statistically sampled Medium comparison confirms Tier-1 parity across UInt32, UInt64, Boolean, and enum setters: geometric mean +0.24%, with every result within tolerance and confidence intervals overlapping.
Validation
dotnet build BitsKit.sln -c Release --no-restore— succeeded with 0 warnings