Optimize generated scalar getters - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
trueMemory<byte>, and inline-array modelsWhy
Generated scalar getters previously delegated to general-purpose
BitPrimitivesmethods even though their offsets, widths, orders, and backing types are compile-time constants. Emitting the operation directly gives the JIT a smaller accessor and avoids an extra helper call in Tier-0 code. It also fixes the signed one-bit Boolean case, where comparing a sign-extended-1result with1returnedfalse.For the representative generated UInt32 MSB getter, disassembly changed from a 45-byte accessor that called
BitPrimitives.ReadUInt32MSBto a 25-byte, call-freebswap/shift sequence. Tier-1 throughput remains effectively tied because the JIT already inlined the old helper.Validation
dotnet build BitsKit.sln -c Release --no-restore— succeeded with 0 warningsdotnet test BitsKit.Tests/BitsKit.Tests.csproj -c Release --framework net8.0— 4,587 passeddotnet test BitsKit.Tests/BitsKit.Tests.csproj -c Release --framework net10.0— 4,587 passed