fix(node): apply per-model arm type to gravity compensation#56
Open
JafarAbdi wants to merge 1 commit into
Open
fix(node): apply per-model arm type to gravity compensation#56JafarAbdi wants to merge 1 commit into
JafarAbdi wants to merge 1 commit into
Conversation
Pass arm_type to direct_scaling_factors and GravityCompensationModel so non-base arms get the correct per-model torque scaling in the node gravity comp.
Greptile SummaryThis PR applies the configured arm type to node gravity compensation. The main changes are:
Confidence Score: 5/5The changed gravity-compensation API boundary needs confirmation before merging.
src/piper_control_ros2/piper_control_ros2/piper_control_node.py Important Files Changed
Reviews (1): Last reviewed commit: "fix(node): apply per-model arm type to g..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass arm_type to direct_scaling_factors and GravityCompensationModel so non-base arms get the correct per-model torque scaling in the node gravity comp.
Depends on Reimagine-Robotics/piper_control#86