Skip to content

fix(node): apply per-model arm type to gravity compensation#56

Open
JafarAbdi wants to merge 1 commit into
mainfrom
feature/arm-model-torque-coefficients
Open

fix(node): apply per-model arm type to gravity compensation#56
JafarAbdi wants to merge 1 commit into
mainfrom
feature/arm-model-torque-coefficients

Conversation

@JafarAbdi

@JafarAbdi JafarAbdi commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Pass arm_type to direct_scaling_factors and GravityCompensationModel so non-base arms get the correct per-model torque scaling in the node gravity comp.

Depends on Reimagine-Robotics/piper_control#86

Pass arm_type to direct_scaling_factors and GravityCompensationModel so non-base arms get the correct per-model torque scaling in the node gravity comp.
@greptile-apps

greptile-apps Bot commented Jul 16, 2026

Copy link
Copy Markdown

Greptile Summary

This PR applies the configured arm type to node gravity compensation. The main changes are:

  • Resolve the configured arm type before gravity model creation.
  • Pass the arm type to direct scaling-factor selection.
  • Pass the arm type to the MuJoCo gravity model.

Confidence Score: 5/5

The changed gravity-compensation API boundary needs confirmation before merging.

  • The node resolves the same configured arm type used for the robot interface.
  • The external gravity-compensation API must accept that enum representation for all configured arm types.

src/piper_control_ros2/piper_control_ros2/piper_control_node.py

Important Files Changed

Filename Overview
src/piper_control_ros2/piper_control_ros2/piper_control_node.py Adds the configured arm type to gravity scaling and model construction.

Fix All in Claude Code Fix All in Codex

Reviews (1): Last reviewed commit: "fix(node): apply per-model arm type to g..." | Re-trigger Greptile

Comment thread src/piper_control_ros2/piper_control_ros2/piper_control_node.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant