Skip to content

Personal link improvements - #55

Merged
J164 merged 1 commit into
mainfrom
registration-improvements
Aug 24, 2025
Merged

J164 merged 1 commit into
mainfrom
registration-improvements

Conversation

@J164

@J164 J164 commented Aug 24, 2025

Copy link
Copy Markdown
Member

Allows personal links to recognize more url formats for github and linkedin
Adds a link preview

@J164
J164 requested review from a team, Timothy-Gonzalez and Copilot August 24, 2025 22:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances personal link handling by improving URL format recognition for GitHub and LinkedIn profiles and adding a link preview feature. The changes make the form more user-friendly by automatically normalizing common URL variations and providing visual feedback.

  • Replaces simple string matching with regex patterns to handle various GitHub and LinkedIn URL formats
  • Adds a clickable link preview that appears when a field is active

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread shared/src/components/form/FormLinks.tsx
Comment thread shared/src/components/form/FormLinks.tsx
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying rp-web-admin with  Cloudflare Pages  Cloudflare Pages

Latest commit: 589cb6f
Status: ✅  Deploy successful!
Preview URL: https://7e5a98b4.rp-web-admin.pages.dev
Branch Preview URL: https://registration-improvements.rp-web-admin.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying rp-web-sponsor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 589cb6f
Status: ✅  Deploy successful!
Preview URL: https://a70e1456.rp-web-sponsor.pages.dev
Branch Preview URL: https://registration-improvements.rp-web-sponsor.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying rp-web-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: 589cb6f
Status: ✅  Deploy successful!
Preview URL: https://a4bc6a4f.rp-web-site.pages.dev
Branch Preview URL: https://registration-improvements.rp-web-site.pages.dev

View logs

@anandani4136 anandani4136 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this, good changes

@J164
J164 removed the request for review from Timothy-Gonzalez August 24, 2025 23:20
@J164
J164 merged commit 6c24384 into main Aug 24, 2025
7 checks passed
@J164
J164 deleted the registration-improvements branch August 24, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants