Registration - #23
Merged
Merged
Conversation
Deploying rp-web-admin with
|
| Latest commit: |
eeec4a3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e97ca30f.rp-web-admin.pages.dev |
| Branch Preview URL: | https://edleyjacob-rp-82-registratio.rp-web-admin.pages.dev |
Deploying rp-web-hype with
|
| Latest commit: |
eeec4a3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fa656ffa.rp-web-hype.pages.dev |
| Branch Preview URL: | https://edleyjacob-rp-82-registratio.rp-web-hype.pages.dev |
…edleyjacob/rp-82-registration
…edleyjacob/rp-82-registration
…nto edleyjacob/rp-82-registration
…nto edleyjacob/rp-82-registration
J164
marked this pull request as ready for review
August 1, 2025 07:51
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a comprehensive registration system with form components, authentication improvements, and API restructuring. The changes focus on creating a multi-step registration form with autosave functionality and updating the shared API architecture.
- Adds a complete registration system with multi-step forms for personal and career information
- Refactors API architecture from factory pattern to singleton with centralized error handling
- Creates reusable form components for various input types (text fields, selects, checkboxes, file uploads)
Reviewed Changes
Copilot reviewed 64 out of 70 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| shared/src/utils/require-auth.tsx | New utility for creating authentication-protected routes |
| shared/src/hooks/form-autosave.ts | Custom hook for automatic form saving with debouncing |
| shared/src/components/form/* | Reusable form components with consistent styling and validation |
| shared/src/api/api.ts | New singleton API instance replacing the factory pattern |
| apps/site/src/routes/Register.tsx | Main registration page with responsive design and multi-step flow |
| apps/*/src/util/api.ts | Removed in favor of centralized API singleton |
Comments suppressed due to low confidence (2)
shared/src/components/form/FormLinks.tsx:103
- This React Fragment should have a key prop since it's inside a map function. Add key={index} to avoid React warnings.
<>
shared/src/components/form/FormFileUpload.tsx:23
- The component is named 'FileUpload' but exported as 'default FileUpload'. This is inconsistent with the filename 'FormFileUpload.tsx'. Consider renaming the component to 'FormFileUpload' for consistency.
const FileUpload = <
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Deploying rp-web-sponsor with
|
| Latest commit: |
eeec4a3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3f2783c9.rp-web-sponsor.pages.dev |
| Branch Preview URL: | https://edleyjacob-rp-82-registratio.rp-web-sponsor.pages.dev |
anandani4136
approved these changes
Aug 15, 2025
anandani4136
left a comment
anandani4136
left a comment
Collaborator
There was a problem hiding this comment.
Alright I'm a huge fan of the incredible new flow – few things to note moving forward
- Lets clean up the final confirmation page
- Restrict file types and file size limits
- Limit amount of options that can be chosen / add character limits to open field values so we don't get text spammed
But for a initial merge, I'm more than happy with this. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.