Skip to content

Massmailer confirmation popup - #119

Merged
J164 merged 1 commit into
mainfrom
admin-notification-alert
Sep 18, 2025
Merged

Massmailer confirmation popup#119
J164 merged 1 commit into
mainfrom
admin-notification-alert

Conversation

@miguelaenlle

Copy link
Copy Markdown
Contributor
  • Added functionality to show "Are you sure you want to send this notification?" alert before actually sending
  • Clears fields when the user sends
  • Tested this by replacing the request promises with setTimeout calls:
new Promise((resolve, reject) => {
   setTimeout(() => {
      resolve(true);
   }, 2000);
 });

Copilot AI review requested due to automatic review settings September 18, 2025 21:10
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying rp-web-dash with  Cloudflare Pages  Cloudflare Pages

Latest commit: 137b763
Status: ✅  Deploy successful!
Preview URL: https://fe9db3f6.rp-web-dash.pages.dev
Branch Preview URL: https://admin-notification-alert.rp-web-dash.pages.dev

View logs

@miguelaenlle
miguelaenlle requested review from a team and Timothy-Gonzalez September 18, 2025 21:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds confirmation functionality to the Massmailer feature, ensuring users confirm before sending notifications or emails. It also improves the user experience by clearing form fields after successful sends.

  • Added confirmation popup using window.confirm() before sending notifications/emails
  • Clear form fields and reset notification type after successful API calls
  • Improved form state management with proper field resets

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread apps/admin/src/routes/pages/Massmailer.tsx
Comment thread apps/admin/src/routes/pages/Massmailer.tsx
Comment thread apps/admin/src/routes/pages/Massmailer.tsx
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying rp-web-hype with  Cloudflare Pages  Cloudflare Pages

Latest commit: 137b763
Status: ✅  Deploy successful!
Preview URL: https://a93d6305.rp-web-hype.pages.dev
Branch Preview URL: https://admin-notification-alert.rp-web-hype.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying rp-web-admin with  Cloudflare Pages  Cloudflare Pages

Latest commit: 137b763
Status: ✅  Deploy successful!
Preview URL: https://b8b639dc.rp-web-admin.pages.dev
Branch Preview URL: https://admin-notification-alert.rp-web-admin.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying rp-web-sponsor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 137b763
Status: ✅  Deploy successful!
Preview URL: https://b8b89218.rp-web-sponsor.pages.dev
Branch Preview URL: https://admin-notification-alert.rp-web-sponsor.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying rp-web-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: 137b763
Status: ✅  Deploy successful!
Preview URL: https://d55b003f.rp-web-site.pages.dev
Branch Preview URL: https://admin-notification-alert.rp-web-site.pages.dev

View logs

@J164 J164 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good!

@J164
J164 merged commit ce7ae11 into main Sep 18, 2025
8 checks passed
@J164
J164 deleted the admin-notification-alert branch September 18, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants